Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7702: Change transaction validity rules according to latest spec #1032

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 27, 2024

This is awaiting updates in EEST.

Copy link

gitguardian bot commented Sep 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13591339 Triggered Generic High Entropy Secret 7b9474e test/state/state.cpp View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (dd33a32) to head (7b9474e).
Report is 1 commits behind head on eip-7702.

Additional details and impacted files
@@             Coverage Diff              @@
##           eip-7702    #1032      +/-   ##
============================================
- Coverage     94.20%   93.42%   -0.78%     
============================================
  Files           156      156              
  Lines         16300    16291       -9     
============================================
- Hits          15355    15220     -135     
- Misses          945     1071     +126     
Flag Coverage Δ
eof_execution_spec_tests 17.60% <ø> (+<0.01%) ⬆️
ethereum_tests 27.18% <ø> (+0.01%) ⬆️
ethereum_tests_silkpre 19.12% <ø> (+0.01%) ⬆️
execution_spec_tests ?
unittests 89.23% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/errors.hpp 52.08% <ø> (+4.00%) ⬆️
test/state/state.cpp 96.79% <ø> (-2.86%) ⬇️

... and 3 files with indirect coverage changes

@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from 7c8e0b8 to dd33a32 Compare October 11, 2024 11:05
@gumb0 gumb0 marked this pull request as ready for review October 17, 2024 12:33
@gumb0 gumb0 merged commit 2d162bb into eip-7702 Oct 17, 2024
22 of 25 checks passed
@gumb0 gumb0 deleted the eip-7702-validity branch October 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant